-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bash dependency #617
Fix bash dependency #617
Conversation
What tests have you performed? I get an error when trying to run
|
The newly added pre-commit check also complains, there seems to be a trailing space in one of the files. See https://github.com/eclipse/kuksa.val/blob/master/README.md#pre-commit-set-up on info how to set up pre-commit checks locally |
Haven't checked, but maybe try a space before the " (", not sure POSIX has something to say about it.... When going the vanilla "sh" (which in your system might actually be anything), at least try with busybox, as that is at least a "likely" target ot be encountered in embedded environments |
Sorry, I didn't see that. |
should work now. |
Signed-off-by: Guenther Meyer <[email protected]>
I have been using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran both scripts locally on my Debian VM, they worked and no regressions.
@SebastianSchildt - I have no problems if this PR gets merged before v0.4.0, it does not affect any release artifacts apart from the source zip
fixes #616