Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate spi module and contents #581

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Deprecate spi module and contents #581

merged 1 commit into from
Jan 19, 2024
+22 −10

Conversation

MikeEdgar
Copy link
Member

Closes #576

@MikeEdgar
Copy link
Member Author

Leaving as a draft until #577 and Java 11 build are merged in order to uncomment the forRemoval property of the @Deprecated annotations.

@MikeEdgar MikeEdgar marked this pull request as ready for review January 18, 2024 16:36
Azquelt
Azquelt approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Azquelt Azquelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is right. I wonder if there's anything we need to do to ensure that when we build the full MicroProfile Javadoc we pick up the API version of this package rather than the SPI one with the deprecation warnings.

@MikeEdgar
Copy link
Member Author

I wonder if there's anything we need to do to ensure that when we build the full MicroProfile Javadoc we pick up the API version of this package rather than the SPI one with the deprecation warnings.

Good question, where is it generated and hosted?

@Azquelt
Copy link
Member

Azquelt commented Jan 19, 2024

Hmm, actually never mind, it doesn't look like the MicroProfile project builds a combined Javadoc anywhere.

We do build one for the Open Liberty docs, but I can poke our docs team to find out how they do it and ask them to not use the SPI jar.

@Azquelt Azquelt closed this Jan 19, 2024
@Azquelt Azquelt reopened this Jan 19, 2024
@MikeEdgar MikeEdgar merged commit db59529 into eclipse:main Jan 19, 2024
6 checks passed
@MikeEdgar MikeEdgar deleted the spi-deprecation branch January 19, 2024 12:13
@MikeEdgar MikeEdgar mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azquelt Azquelt Azquelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider deprecating/removing the spi package in the api module
2 participants
@MikeEdgar @Azquelt