Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content assist shows to many elements #334

Open
1 of 4 tasks
tkutz opened this issue May 20, 2019 · 2 comments
Open
1 of 4 tasks

Content assist shows to many elements #334

tkutz opened this issue May 20, 2019 · 2 comments

Comments

@tkutz
Copy link
Contributor

tkutz commented May 20, 2019

Current behavior:

The content assist shows too many elements. Selecting the wrong ones results in compilation errors.

Expected behavior:

Only elements that are relevant in the corresponding context should be provided.

List of issues:

  • In event handler code, feature call on sensor should only show modalities
  • Feature call on variable should only show type members and available extension methods
  • Feature call on modality should only show type members and available extension methods
  • Content assist for setup block should filter for imported platforms
@tkutz
Copy link
Contributor Author

tkutz commented May 21, 2019

I took a look into this but it seems to be trickier than I thought. When having typed mysensor01. and pressing [ctrl+space] after the dot, I end up in the scoping rule for ElementReferenceExpression_reference which is clear so far. However, the feature call owner mysensor01 does not refer to a Sensor type; it refers to a TypeKind. I find that quite confusing, as it also breaks hyperlinking.

@tkutz tkutz self-assigned this May 21, 2019
@tkutz
Copy link
Contributor Author

tkutz commented May 21, 2019

Working branch is "334-scoping"

@wegendt-bosch wegendt-bosch self-assigned this May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants