Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for filtering in autocomplete renderer #1239

Closed
AlexandraBuzila opened this issue Jan 22, 2019 · 7 comments · Fixed by #2217
Closed

Add tests for filtering in autocomplete renderer #1239

AlexandraBuzila opened this issue Jan 22, 2019 · 7 comments · Fixed by #2217
Assignees
Milestone

Comments

@AlexandraBuzila
Copy link
Member

AlexandraBuzila commented Jan 22, 2019

Add tests for #1182 (see fix in #1223).

@howdyAnkit
Copy link
Contributor

Hi is this issue still opened?

@AlexandraBuzila
Copy link
Member Author

Hi @howdyAnkit

Yes, this is still open. The tests for the shouldFilter prop are currently missing.

@howdyAnkit
Copy link
Contributor

Can you assign it to me and show me where is this file?
is it this one that we have to cover jasmine test cases ?
packages/angular-material/src/controls/autocomplete.renderer.ts

@AlexandraBuzila
Copy link
Member Author

Hi @howdyAnkit

Thank you for taking this on! 💟

Yes, the control that's missing the test case is the angular-material autocomplete renderer. You can find it here.

The existing tests for the control can be found here.

@howdyAnkit
Copy link
Contributor

howdyAnkit commented Aug 24, 2023

How do you check the coverage and is there any command which you can help me with to start the karma config or something similar ?

@AlexandraBuzila
Copy link
Member Author

After following the steps from the developer documentation, you should be able to run the angular-material tests like this: cd packages/angular-material && pnpm run test.

To get the test coverage, you can use pnpm run test-cov. The coverage results will be in packages/angular-material/coverage

@howdyAnkit
Copy link
Contributor

Hi @AlexandraBuzila

Sorry for taking this much time I almost forgot the track of it.

I've attached the PR #2217 for you reference regarding the issue

Also a small headsup
options should prefer own props
This mentioned testcase was quite unstable to run this test on my system and was passing and failing sometimes.

Please do run once in your system and if it still fails i'll check on your suggestions.

Again thanks for making this awesome library and Checking

@sdirix sdirix modified the milestones: Backlog, 3.2 Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants