Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show available information in Slice Details 715 #86

Open
wants to merge 1 commit into
base: reuse_timeline
Choose a base branch
from
Open

Only show available information in Slice Details 715 #86

wants to merge 1 commit into from
+3 −0

Conversation

ALevansSamsung
Copy link
Collaborator

dfriederich
dfriederich reviewed Jun 18, 2024
View reviewed changes
ui/src/frontend/chrome_slice_panel.ts Outdated
@@ -522,6 +522,9 @@ export class ChromeSliceDetailsPanel extends SlicePanel {
contents));
const value = row.contents.value;
if (typeof value === 'string') {
if (value === 'null') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is this not possibly hiding real intentional 'null' string values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfriederich dfriederich dfriederich left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ALevansSamsung @dfriederich