Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roocs adaptor to use retrieve_list_of_results method #214

Open
EddyCMWF opened this issue Sep 30, 2024 · 0 comments
Open

Roocs adaptor to use retrieve_list_of_results method #214

EddyCMWF opened this issue Sep 30, 2024 · 0 comments
Assignees

Comments

@EddyCMWF
Copy link
Contributor

EddyCMWF commented Sep 30, 2024

For consistency with other adaptors, the Roocs adaptor should use the retrieve_list_of_results method.

This returns a list of paths, and is called by the default self.retrieve method. The self.make_download_object is then responsible turning the list of paths into a downloadable object for the retreive-api.

If the default self.make_download_object is incompatible with the adaptor, then please define your own retrieve method which handles the creation of a download object, which must be an open binary file.

This will give more flexibility with anticipated functionality, and allows use with the MultiAdaptor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants