Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply_constraints does not need a fully instantiated adaptor #137

Open
EddyCMWF opened this issue Jul 27, 2023 · 0 comments
Open

apply_constraints does not need a fully instantiated adaptor #137

EddyCMWF opened this issue Jul 27, 2023 · 0 comments
Assignees

Comments

@EddyCMWF
Copy link
Contributor

EddyCMWF commented Jul 27, 2023

apply_constraints does not need a fully instantiated adaptor.

At the moment the web portal is instantiating the full adaptor when evaluating the constraints. As the constraints algorithm is the same for all adaptors*, only the abstract adaptor needs to be instantiated. This will reduce the number of web-portal errors whilst developing new adaptors etc, and may reduce any lag caused by instantiating none Abstract adaptors.

  • It is possible that we may implement different constraints algorithms, but this would not be on a "per dataset" basis, but more likely on a "per portal" basis. To that end, it may make sense to have the constraints algorithm in this repo instead in the cads-adaptors repo.
@EddyCMWF EddyCMWF self-assigned this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant