Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(models): 74 imputer inference mode #127

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

sahahner
Copy link
Member

Description

PR from @JesperDramsch from anemoi-model: ecmwf/anemoi-models#75

This resets the nan_locations in the BaseImputer during non-training runs of the code.

Specifically, this enables changes in the dataset after training.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

Closes #34

Code Compatibility

  • I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass
  • I have tested the changes on a single GPU
  • I have tested the changes on multiple GPUs / multi-node setups
  • I have run the Benchmark Profiler against the old version of the code

Dependencies

  • I have ensured that the code is still pip-installable after the changes and runs
  • I have tested that new dependencies themselves are pip-installable.
  • I have not introduced new dependencies in the inference portion of the pipeline

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

None

@github-actions github-actions bot added models bug Something isn't working enhancement New feature or request labels Feb 10, 2025
@sahahner sahahner changed the title Models fix/74 imputer inference mode fix/74 imputer inference mode (models) Feb 10, 2025
@sahahner sahahner changed the title fix/74 imputer inference mode (models) fix(models) 74 imputer inference mode Feb 10, 2025
@sahahner sahahner changed the title fix(models) 74 imputer inference mode fix(models): 74 imputer inference mode Feb 10, 2025
@sahahner sahahner merged commit 0a9cfa7 into main Feb 10, 2025
29 of 32 checks passed
@sahahner sahahner deleted the models_fix/74-imputer-inference-mode branch February 10, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request models
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Imputer should have an inference mode
3 participants