Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a naming for "pre_processors" vs "preprocessors" (and "post_processors" vs "postprocessors") #57

Open
floriankrb opened this issue Oct 7, 2024 · 2 comments

Comments

@floriankrb
Copy link
Member

To make the code consistent, I think we should choose one convention:

Either use pre_processor and PreProcessor and "pre-processor"
Or use preprocessor and Preprocessor and "preprocessor"

We currently have a mix of both.

https://github.com/search?q=repo%3Aecmwf%2Fanemoi-models%20preprocessor&type=code
https://github.com/search?q=repo%3Aecmwf%2Fanemoi-models%20pre_processor&type=code

Same thing for post-processors.

I have no preference but mixing names is not ideal. Any opinion?

@floriankrb
Copy link
Member Author

Thumbs up here for "pre_processor"

@floriankrb
Copy link
Member Author

Thumbs up here for "preprocessor"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant