You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issues with Loss Implementation in anemoi-training
Nomenclature:
The current implementation uses self.loss_weights for weighting in the spatial dimension and self.data_variances for weighting in the feature dimension. However, this naming can be confusing given that the default strategy for feature dimension weighting is not based on data_variances.
Proposal: Rename self.loss_weights to self.node_weight (for spatial dimension) and self.data_variances to self.feature_weight (for feature dimension). Additionally, modify the function responsible for generating feature scaling values to support various feature scaling strategies.
Consistency in Feature Scaling for Loss Calculation:
The loss calculated by self.metrics does not currently apply feature scaling, whereas the loss used during training does apply the prescribed feature scaling. Previously, feature scaling was applied consistently across both metrics and training losses.
Proposal: Either revert to the previous behavior where feature scaling is applied to both, or introduce an option for users to specify whether feature scaling should be applied in self.metrics.
Monitoring and Recording Loss Types During Validation:
Currently, only WeightedMSELoss is available for monitoring and recording during validation. This limitation restricts flexibility in evaluating model performance.
Proposal: Extend the configuration options to allow for:
a) Selection of the type of loss/metric to record.
b) Choice of whether to record metrics on processed or unprocessed features when evaluating single features (This is crucial for evaluating performance of model's that use different weighting strategies)
What are the steps to reproduce the bug?
NA - Inspect code
Version
develop
Platform (OS and architecture)
NA
Relevant log output
No response
Accompanying data
No response
Organisation
ECMWF
The text was updated successfully, but these errors were encountered:
Issues with Loss Implementation in
anemoi-training
Nomenclature:
self.loss_weights
for weighting in the spatial dimension andself.data_variances
for weighting in the feature dimension. However, this naming can be confusing given that the default strategy for feature dimension weighting is not based ondata_variances
.self.loss_weights
toself.node_weight
(for spatial dimension) andself.data_variances
toself.feature_weight
(for feature dimension). Additionally, modify the function responsible for generating feature scaling values to support various feature scaling strategies.Consistency in Feature Scaling for Loss Calculation:
self.metrics
does not currently apply feature scaling, whereas the loss used during training does apply the prescribed feature scaling. Previously, feature scaling was applied consistently across both metrics and training losses.self.metrics
.Monitoring and Recording Loss Types During Validation:
WeightedMSELoss
is available for monitoring and recording during validation. This limitation restricts flexibility in evaluating model performance.a) Selection of the type of loss/metric to record.
b) Choice of whether to record metrics on processed or unprocessed features when evaluating single features (This is crucial for evaluating performance of model's that use different weighting strategies)
What are the steps to reproduce the bug?
NA - Inspect code
Version
develop
Platform (OS and architecture)
NA
Relevant log output
No response
Accompanying data
No response
Organisation
ECMWF
The text was updated successfully, but these errors were encountered: