Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap out-of-bounds source cells into the domain #211

Merged

Conversation

twsearle
Copy link
Contributor

Description

Recent work on adding a halo size > 0 to atlas-orca (ecmwf/atlas-orca#19) revealed an issue in the North fold of the orca grid when comparing MPI to non-MPI interpolations.

This issue was traced to the interpolator not properly accounting fully for the wrapping of the source interpolation mesh cell when it crosses the periodic boundary.

This change fixes this issue by properly validating each cell.

The change was proposed by Simon Good, I am just performing the necessary admin to get the change into atlas.

Testing

This is tricky to test, and requires a separate PR in atlas-orca to introduce a ctest to cover the issue.

An example of some of the affected interpolated points that were incorrect before this change and fixed afterwards on an eORCA025_T:

hofx_differences

Change originally proposed by s-good, twsearle is just here for the PR
admin.

Co-authored-by: s-good <[email protected]>
Copy link
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial :)

@wdeconinck wdeconinck merged commit 8981cd1 into ecmwf:develop Jul 4, 2024
140 of 141 checks passed
@twsearle twsearle deleted the bugfix/wrap-out-of-bounds-source-cells branch July 12, 2024 10:09
wdeconinck added a commit that referenced this pull request Jul 15, 2024
* hotfix/0.38.1:
  Update Changelog
  Version 0.38.1
  NAG fixes. (#213)
  Wrap out-of-bounds source cells into the domain (#211)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants