Wrap out-of-bounds source cells into the domain #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent work on adding a halo size > 0 to atlas-orca (ecmwf/atlas-orca#19) revealed an issue in the North fold of the orca grid when comparing MPI to non-MPI interpolations.
This issue was traced to the interpolator not properly accounting fully for the wrapping of the source interpolation mesh cell when it crosses the periodic boundary.
This change fixes this issue by properly validating each cell.
The change was proposed by Simon Good, I am just performing the necessary admin to get the change into atlas.
Testing
This is tricky to test, and requires a separate PR in atlas-orca to introduce a ctest to cover the issue.
An example of some of the affected interpolated points that were incorrect before this change and fixed afterwards on an eORCA025_T: