Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HIC abstraction layer for HIP and CUDA #219

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Add HIC abstraction layer for HIP and CUDA #219

merged 4 commits into from
Aug 22, 2024

Conversation

wdeconinck
Copy link
Member

@wdeconinck wdeconinck commented Aug 21, 2024

Currently this is implemented as a stand-alone CMake package within the atlas repository.

A dummy API is available when HIP or CUDA backend is not available, to avoid #ifdef in downstream code.

Atlas has been adapted to replace all use of CUDA API with the new hic API.
Even though hic is tested with HIP backend, the use of Atlas with hic has not been tested with the HIP backend. A future PR may address small fixes needed.

@wdeconinck wdeconinck requested a review from sbrdar August 21, 2024 09:37
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10489952082.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10493908782.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10494127731.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.36364% with 17 lines in your changes missing coverage. Please review.

Project coverage is 79.95%. Comparing base (74baa23) to head (afd3b5f).
Report is 7 commits behind head on develop.

Files Patch % Lines
hic/src/hic/hic_dummy/hic_dummy_runtime.h 30.00% 7 Missing ⚠️
src/atlas/util/Allocate.cc 50.00% 4 Missing ⚠️
hic/tests/test_hic_dummy.cc 81.25% 3 Missing ⚠️
src/atlas/util/Allocate.h 50.00% 2 Missing ⚠️
hic/src/hic/hic_runtime.h 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #219      +/-   ##
===========================================
+ Coverage    79.40%   79.95%   +0.55%     
===========================================
  Files          794      792       -2     
  Lines        54315    62309    +7994     
===========================================
+ Hits         43131    49822    +6691     
- Misses       11184    12487    +1303     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10505432438.

1 similar comment
Copy link

Private downstream CI succeeded.
Workflow name: private-downstream-ci
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10505432438.

Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10505615284.

@wdeconinck wdeconinck merged commit af38cfa into develop Aug 22, 2024
45 checks passed
Copy link

Private downstream CI failed.
Workflow name: private-downstream-ci-hpc
View the logs at https://github.com/ecmwf-actions/private-downstream-ci/actions/runs/10511466778.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants