-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HIC abstraction layer for HIP and CUDA #219
Conversation
Private downstream CI failed. |
Private downstream CI succeeded. |
Private downstream CI failed. |
e93bf86
to
afd3b5f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #219 +/- ##
===========================================
+ Coverage 79.40% 79.95% +0.55%
===========================================
Files 794 792 -2
Lines 54315 62309 +7994
===========================================
+ Hits 43131 49822 +6691
- Misses 11184 12487 +1303 ☔ View full report in Codecov by Sentry. |
Private downstream CI succeeded. |
1 similar comment
Private downstream CI succeeded. |
Private downstream CI failed. |
afd3b5f
to
cd856d3
Compare
Private downstream CI failed. |
Currently this is implemented as a stand-alone CMake package within the atlas repository.
A dummy API is available when HIP or CUDA backend is not available, to avoid
#ifdef
in downstream code.Atlas has been adapted to replace all use of CUDA API with the new hic API.
Even though hic is tested with HIP backend, the use of Atlas with hic has not been tested with the HIP backend. A future PR may address small fixes needed.