Bug fixes to vector interpolation with StructuredColumns and spherical vector interpolation #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #222 +/- ##
===========================================
+ Coverage 79.95% 79.99% +0.03%
===========================================
Files 792 792
Lines 62309 62363 +54
===========================================
+ Hits 49822 49888 +66
+ Misses 12487 12475 -12 ☔ View full report in Codecov by Sentry. |
|
@wdeconinck - looks like a private-downstream-ci-hpc failed. Do I need to increase the tolerance on any of the new tests? |
Thanks @MarekWlasak it looks like it's not related to Atlas but one specific cmake configuration failing, so nothing to do on your part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a set of minor bug-fixes
The most notable (and contentious) is that for the vector interpolation it is currently assuming that the
levelshave been given to StructuredColumns at construction. For most functionspaces this is not the case, so I have added a small change that will allow the changing of the sign in the 3D case, whenlevelsis not set in the functionspace but instead in the field.I have added a number of additional tests to
test_interpolation_spherical_vector.ccincluding the classic Gauss state and cubic interpolation.