Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate masks and mask functions #14

Closed
EddyCMWF opened this issue May 3, 2024 · 0 comments · Fixed by #38
Closed

Consolidate masks and mask functions #14

EddyCMWF opened this issue May 3, 2024 · 0 comments · Fixed by #38
Assignees
@EddyCMWF
Labels
enhancement New feature or request

Comments

@EddyCMWF
Copy link
Collaborator

EddyCMWF commented May 3, 2024

Is your feature request related to a problem? Please describe.

not required to two methods for very similar functionality.
mask should take the functionality of masks, i.e. return masked data for each feature in the geometry object, with an optional flag to squash the geometries into a single mask.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Organisation

No response
@EddyCMWF EddyCMWF added the enhancement New feature or request label May 3, 2024
@EddyCMWF EddyCMWF self-assigned this Jul 3, 2024
@EddyCMWF EddyCMWF linked a pull request Nov 28, 2024 that will close this issue
13 precomputed masks #38
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EddyCMWF EddyCMWF

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

13 precomputed masks ecmwf/earthkit-transforms
1 participant
@EddyCMWF