Can not include contrib/ecwam from a bundle

[dhaumont]

What happened?

In a bundle, including a project with dir pointing to contrib/ecwan will generate the following error message in ifs-bundle:

A directory [ifs-source/contrib/ecwam] is provided for project [ecwam_dp] but it does not exist.

Workaround

Create an ecwam link pointing to contrib/ecwam and use ecwam in the bundle.yml

What are the steps to reproduce the bug?

1. In your bundle, including a project with dir pointing to contrib/ecwan:

- ifs-source :
        git     : [email protected]:dhaumont/IAL.git
        version : CY50T1_ial_bundle
        bundle  : false

- ecwam_dp :
        dir     : ifs-source/contrib/ecwam

2. Create the project, this will trigger the error message:

$ ifs-bundle create
...
A directory [ifs-source/contrib/ecwam] is provided for project [ecwam_dp] but it does not exist.

Workaround

1. Create an ecwam link pointing to contrib/ecwam and use ecwam in the bundle.yml

ln -s contrib/ecwan ecwam

2. Use ifs-source/ecwam in bundle.yml

- ifs-source :
        git     : [email protected]:dhaumont/IAL.git
        version : CY50T1_ial_bundle
        bundle  : false

- ecwam_dp :
        dir     : ifs-source/ecwam

Version

2.2.0

Platform (OS and architecture)

Atos

Relevant log output

Accompanying data

No response

Organisation

No response

[wdeconinck]

Hi @dhaumont could you try to reproduce with latest version 2.2.2?
It could have been fixed with #20

[dhaumont]

@wdeconinck I re-tested with 2.2.2 and I confim that it is solved.

I just had another error: I had to launch the "create" two times to get the setup right. This is because ecwam_dp is created first, and an error is reported that the folder contrib/ecwam, does not exist, which is true since it is only created when ifs-source is cloned.
Is it a problem in my bundle definition, or is it something that should be managed by ecbundle?

bundle.yml.txt

[wdeconinck]

Thanks @dhaumont I can reproduce the error.
ecbundle was being too cautious in creating symlinks for things it could not yet know will exist when parsing.

For the case of ifs_dp, ifs_sp it could already know that there was a project ifs-source to be git-downloaded that it could symlink to. It could not yet detect there would be a contrib/ecwam within ifs-source at the time of parsing. I will see what I can do to fix.

[wdeconinck]

@dhaumont please check if PR #25 solves the issue for you.
Trying to use your bundle, I noticed that nemo is no longer present in your ifs-source fork (in location ifs-source/nemo), so that the nemo_sp and nemo_dp dir will fail, unrelated to this issue.