Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/clean up optimisation #73

Merged
merged 43 commits into from
Nov 23, 2023
Merged

Conversation

mathleur
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 292 lines in your changes are missing coverage. Please review.

Comparison is base (c95438f) 96.06% compared to head (d4697b8) 92.36%.
Report is 8 commits behind head on develop.

❗ Current head d4697b8 differs from pull request most recent head 3312772. Consider uploading reports for the commit 3312772 to get more accurate results

Files Patch % Lines
polytope/datacube/backends/fdb.py 10.85% 115 Missing ⚠️
...ytope/datacube/transformations/datacube_mappers.py 58.33% 60 Missing ⚠️
polytope/datacube/datacube_axis.py 37.77% 56 Missing ⚠️
tests/test_regular_grid.py 24.56% 43 Missing ⚠️
polytope/datacube/index_tree.py 45.45% 12 Missing ⚠️
tests/test_hull_slicer.py 44.44% 5 Missing ⚠️
tests/test_fdb_datacube.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
- Coverage    96.06%   92.36%   -3.70%     
===========================================
  Files           60       63       +3     
  Lines         6278     6551     +273     
===========================================
+ Hits          6031     6051      +20     
- Misses         247      500     +253     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathleur mathleur merged commit 3312772 into develop Nov 23, 2023
1 check passed
@mathleur mathleur deleted the feature/clean_up_optimisation branch November 23, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants