Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No region found within the locale 'de' - exception due to empty locale with Zend_Locale_Format #7

Open
johnorourke opened this issue May 12, 2020 · 1 comment

Comments

@johnorourke
Copy link
Contributor

The Zend class throws an exception if the locale is empty or not 5 characters long.

We are relying on CurrencyInterface->getLocale() to find the currency locale but it looks like this can be empty, or taken from the user's Accept-Language header. If the Accept-Language header contains only 'de' (not 'de_DE'), then the exception is thrown.

We should use the Magento locale resolver instead as it will always return a valid locale.

@johnorourke
Copy link
Contributor Author

(I will send a PR for this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant