Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include taker account/order info on taker events #147

Open
bogberry opened this issue Apr 20, 2023 · 1 comment
Open

Include taker account/order info on taker events #147

bogberry opened this issue Apr 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@bogberry
Copy link
Contributor

The existing taker events only include information about the maker account and order, and not the taker.

The taker receives no event to confirm that their order was successfully placed and filled when it is successful. Consequently, it is impossible to send order status updates for taker orders on the WebSocket API, which most exchange APIs offer.

A future version of the move code should either include this information, or alternatively, if we go with #146, emit separate events to both the maker account and the taker account, including the fields that are relevant to the respective user.
@bogberry bogberry added the enhancement New feature or request label Apr 20, 2023
@alnoki
Copy link
Member

alnoki commented Jul 1, 2023

The taker receives no event to confirm that their order was successfully placed and filled when it is successful.

See #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alnoki @bogberry