Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert source from CoffeeScript to JavaScript or TypeScript or Civet? #45

Closed
mayakraft opened this issue Jun 3, 2023 · 5 comments · May be fixed by #47
Closed

Convert source from CoffeeScript to JavaScript or TypeScript or Civet? #45

mayakraft opened this issue Jun 3, 2023 · 5 comments · May be fixed by #47

Comments

@mayakraft
Copy link
Contributor

Just wanted to throw this out there to gauge a response:

Can we convert the src/ folder from coffee script into ES6 Javascript or Typescript?

This would be for the sole purpose of getting more code contributions from the community. If it resulted in no increase in contribution activity I would feel like I wasted everyone's time. Can we leave this issue open for a while, and if anyone has feelings about this would you like to leave a response?

1,300-1,700 lines of coffee script code, no tests to port.

@mayakraft
Copy link
Contributor Author

mayakraft commented Jun 3, 2023

Personally, I think ES6 Javascript (with JSDoc style comments) over Typescript for a few reasons:

  • simpler build tooling
  • strong types slow down development time
  • the flexibility it allows for projects in exploratory phases
  • can still generate .d.ts file with pure Javascript and JSDocs link

Rich Harris took the words out of my mouth recently. link

@edemaine
Copy link
Owner

edemaine commented Jun 3, 2023

Related to #25 which we should definitely do one way or another.

Personally I'd rather go in the other direction and port to Civet. This would be an easier transition (as it's mostly CoffeeScript compatible), and because it's largely TypeScript compatible (most shorthand is optional), maybe it would be better for others contributing? (Not sure - it still might be intimidating.)

@mayakraft
Copy link
Contributor Author

That's cool. in that case, Civet might be the best solution concerning types and ease of translation. Not sure I would bet on it if the aim is to increase community contributions. In that case I might still push for JS/TS as the safer bet. But, again, whatever people think! happy to hear more thoughts.

@edemaine edemaine changed the title convert source from coffee script to javascript Convert source from CoffeeScript to JavaScript or Civet? Jun 25, 2023
@edemaine edemaine changed the title Convert source from CoffeeScript to JavaScript or Civet? Convert source from CoffeeScript to JavaScript or TypeScript or Civet? Jun 25, 2023
@edemaine edemaine linked a pull request Oct 28, 2023 that will close this issue
@MuTsunTsai
Copy link

If the motivation is to invite more contribution, I will certainly recommend TypeScript over alternatives. TypeScript is the de facto standard of JS development, while Civet is, to be honest, almost never discussed within the JS community, despite the hard work by @edemaine. Some numbers to support my point:
https://npmtrends.com/@danielx/civet-vs-coffeescript-vs-typescript

@mayakraft
Copy link
Contributor Author

I notice this happened on another thread. thanks for the help @Mokshit06 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants