Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for confirmation before executing a "crouton-simple-button" command #23

Open
gerardovf opened this issue Sep 4, 2016 · 4 comments

Comments

@gerardovf
Copy link

This is not an issue but a new feature.
I'd like to have a confirmation option for the "crouton-simple-toggle", "crouton-simple-button", cards.
Thanks!

@edfungus
Copy link
Owner

edfungus commented Oct 5, 2016

What kind of confirmation were you looking for? A "Are you sure?" or confirmation that the action has happened?

For the latter, the state of the toggle and button actually reflect the current state because the mechanism is as follows:

  1. Button pushed on Crouton
  2. Devices receives message and returns confirmation message to Crouton
  3. Crouton gets confirmation message and updates UI

@gerardovf
Copy link
Author

I was thinking in an "Are you sure?" popup asking the user to select "Yes" or "No"

@edfungus
Copy link
Owner

edfungus commented Oct 6, 2016

Perhaps I can make that an option for that card. I feel like during normal use, the confirmation popup could get frustrating since I would assume that most of the time you do want to toggle the button

@gerardovf
Copy link
Author

gerardovf commented Oct 6, 2016

Imagine you want to open your garage door and you don't have a feedback telling you that your garage door is open, it would be dangerous to execute commands without been aware of them. You could have a new option: "alert": "Are you sure?" in "crouton-simple-button".
If the option is missing or the text value is empty then the button would behave as it is now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants