Add warnings handler #1115
Merged
Add warnings handler #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotttrinh
approved these changes
Oct 8, 2024
| @@ -1230,7 +1272,7 @@ export class BaseRawConnection { | |||
| (!inCodec && args !== null) || | |||
| (this.stateCodec === INVALID_CODEC && state !== Session.defaults()) | |||
| ) { | |||
| [card, inCodec, outCodec] = await this._parse( | |||
| [card, inCodec, outCodec, _, _, _, warnings] = await this._parse( | |||
There was a problem hiding this comment.
btw, I think these _ variable names are unnecessary? Maybe eslint would complain if you did this, but I think this is equivalent:
Suggested change
| [card, inCodec, outCodec, _, _, _, warnings] = await this._parse( | |
| [card, inCodec, outCodec,,,, warnings] = await this._parse( |
Just a tiny nit, not even something I'm suggesting we do here, just putting it out there.
There was a problem hiding this comment.
Huh, I didn't know you could do that 🌈⭐. Though I think I prefer the underscores as it looks more intentional to me, and not that I've just typoed it.
| const error_type = this.constructor as typeof EdgeDBError as any; | ||
| return Boolean(error_type.tags?.[tag]); | ||
| hasTag(tag: tags): boolean { | ||
| const error_type = this.constructor as typeof EdgeDBError; |
| let warnings: EdgeDBError[] | null = null; | ||
| client = client.withWarningHandler((_warnings) => (warnings = _warnings)); | ||
|
|
||
| await expect(client.query("select _warn_on_call();")).resolves.toEqual([0]); |
There was a problem hiding this comment.
This is some kind of built-in?
There was a problem hiding this comment.
Yes, Sully 'documented' it here: edgedb/edgedb#7823. I think it only exists in test mode/dev mode though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See edgedb/edgedb#7822 for details.