Doc fixes from quickstart #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had these types defined out-of-order from how they're defined in the quickstart. Also, use `sdl-diff` to make it more clear what is changing from the prior schema. Also gives another indication that this is a continuation of the quickstart.
Object interfaces have `id` properties on them, but we were not selecting them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some feedback about some friction in the quickstart flow, so I went through it myself again and found lots of small things we can do to improve some of this. There are larger changes we should consider as well, but this seems like a good low-effort/high-value start. Especially egregious is that we were using the
Movietype, but not selecting the full shape that fits that interface! 😱