Make first querybuilder example runnable #727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was confusing to see an incomplete and non-runnable example in the middle of the documentation (we forgot to import the
e
default export), so I made the very first example a runnable example so that all of the following examples could assume a similar setup.One sort-of awkward exception is the part where we're inferring the type with the
$infer
type helper. We show some module importing there too, but since we're not running any async code, we don't need a wrapping function. I wonder if we should show$infer
in that first example, too, and just give more details in the "Extracting the inferred type" section? 🤔