Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement DecodeScalar for Bytes #337

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

ifiokjr
Copy link
Contributor

@ifiokjr ifiokjr commented Aug 26, 2024

Fixes #334

@edgedb-cla
Copy link

edgedb-cla bot commented Aug 26, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Contributor

@aljazerzen aljazerzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you.

@ifiokjr
Copy link
Contributor Author

ifiokjr commented Aug 26, 2024

@aljazerzen 20 minutes to build the nix environment seems excessive.

I'm also using nix with a similar set of dependencies and the total setup time is 2 minutes: https://github.com/ifiokjr/edgedb_codegen/actions/runs/10557862386/job/29246247502

It uses heavy caching and helps provide a faster feedback look. Are you happy for me to set up the same for this project?

@aljazerzen
Copy link
Contributor

Yes it is :D Although I've just updated the toolchain and it had to rebuild the env.

Go ahead. The few requirements are:

  • we want a dev shell for the toolchain defined in rust-toolchain.toml (there are people who want to use rustup),
  • we want to test current (1.80 atm), minimum and beta versions.

@aljazerzen
Copy link
Contributor

There is some caching set-up but it is apparently not working correctly.

@aljazerzen aljazerzen merged commit 99de7ec into edgedb:master Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queryable is not implemented for all Value variants
2 participants