Fix useModal hook placeholders

edgedb · Sep 10, 2024 · 5ac60e3 · 5ac60e3
1 parent 09c9882
commit 5ac60e3
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/shared/common/hooks/useModal/index.tsx b/shared/common/hooks/useModal/index.tsx
@@ -92,8 +92,6 @@ export function ModalProvider({children}: PropsWithChildren<{}>) {
   );
 }
 
-const modalPlaceholder = <></>;
-
 export function useModal(): {
   modal: JSX.Element | null;
   openModal: (modal: JSX.Element | null, transition?: boolean) => () => void;
@@ -109,6 +107,7 @@ export function useModal(modal?: JSX.Element): {
     | ((transition?: boolean) => () => void);
 } {
   const ctx = useContext(modalContext);
+  const placeholder = useRef(<></>);
 
   if (!modal) {
     return {
@@ -119,11 +118,11 @@ export function useModal(modal?: JSX.Element): {
 
   return {
     modal:
-      ctx.modal === modalPlaceholder
+      ctx.modal === placeholder.current
         ? createPortal(modal, document.getElementById("modal_target")!)
         : null,
     openModal: (transition?: boolean) =>
-      ctx.openModal(modalPlaceholder, transition),
+      ctx.openModal(placeholder.current, transition),
   };
 }