Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differ() isn't a robust way of differentiating facilities because of the way EPA stores program IDs. #62

Open
ericnost opened this issue Jan 25, 2024 · 0 comments
Assignees
Milestone

Comments

@ericnost
Copy link
Member

This isn't a robust way of differentiating facilities because of the way EPA stores program IDs.

The differ function is meant to take data like:
all_facilities = [A, B, C, D, E]
facilities_with_inspections = [C, D]
and calculate:
facilities_without_inspections = [A, B, E]

But in reality, facility/program IDs are more like:
all_facilities = [A X, B Y, C, D Z, E]
facilities_with_inspections = [C, D]
So the resulting list of facilities without inspections would incorrectly be:
A X, B Y, D Z
even though D does have an inspection.

Just need a way to parse apart program IDs, ideally without having to call up the database to look at the EXP_PGM table.

Originally posted by @ericnost in #50 (comment)

@ericnost ericnost self-assigned this Jan 25, 2024
@ericnost ericnost added invalid This doesn't seem right and removed invalid This doesn't seem right labels Jan 25, 2024
@ericnost ericnost added this to the v0.2.0 milestone Jan 25, 2024
@ericnost ericnost moved this to Todo in ECHO_modules Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant