Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes queryable by annotation fields #239

Closed
Mr0grog opened this issue Mar 2, 2018 · 4 comments
Closed

Make changes queryable by annotation fields #239

Mr0grog opened this issue Mar 2, 2018 · 4 comments
Labels
API Changes to the public API idea stale

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Mar 2, 2018

Similar to what we do with source_metadata in versions_controller, we should make the current_annotation field queryable in changes_controller. We should probably also expose a /api/v0/changes route (so you don’t need a particular page to search on).

This is especially useful to start thinking about now since #233 lets us pull in Analyst annotations from Google sheets and this querying would let analysts do a large-scale analytical look at their annotations.

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2019
@Mr0grog
Copy link
Member Author

Mr0grog commented Jan 10, 2019

This is definitely still worth doing.

@stale stale bot removed the stale label Jan 10, 2019
@Mr0grog Mr0grog added API Changes to the public API idea labels Jan 10, 2019
@Mr0grog
Copy link
Member Author

Mr0grog commented Apr 24, 2019

Split out creating the basic route to #519. This can stay focused on what things should be queryable.

@stale
Copy link

stale bot commented Oct 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Oct 21, 2019
@stale stale bot closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the public API idea stale
Projects
None yet
Development

No branches or pull requests

1 participant