Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffs: could/should we show that the content of a subresource (e.g. an image) changed? #91

Open
Mr0grog opened this issue Jan 19, 2018 · 3 comments

Comments

@Mr0grog
Copy link
Member

Mr0grog commented Jan 19, 2018

So this is an interesting one. If a subresource like an image keeps the same URL across versions, but its content changes, could and should we do something to highlight that?

Here’s an example: https://monitoring.envirodatagov.org/page/80781ac3-2cfe-49e6-b00e-5407d164e78c/57cc3443-f570-4373-b2b3-4e7ebef2780e..6480c3ae-8372-4368-a640-a595c0531d20: you can see that the banner image changed sizes here. That’s actually because the banner image itself changed (see the earlier one at Internet Archive), even though the URL of the <img> tag did not.

There’s no way to solve this with Versionista; we just can’t get the relevant data from it (if you click through to Versionista for that change, you’ll see it highlighted, but only because the height attribute on the <img> tag changed, not because the content of the image did—Versionista can’t do any better with its own data than we can). But with IA, we could: if, when we archived the page, we also pulled all its subresources and hashed them, we could know if the target of an <img> tag (or audio, video, iframe, etc.) was different even when the URL remained the same. (Or conversely, if the target was the same but just got moved to a different URL!) It would be a fair bit more work. Would it be useful?

@danielballan
Copy link
Contributor

Sounds useful to me, but likely a post-v0.1 concern.

@stale
Copy link

stale bot commented Jan 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2019
@Mr0grog Mr0grog added the idea label Jan 10, 2019
@Mr0grog
Copy link
Member Author

Mr0grog commented Jan 10, 2019

Perfect candidate for the new, unstale-able “idea” tag :D

@Mr0grog Mr0grog removed the stale label Jan 10, 2019
@stale stale bot added the stale label Aug 19, 2020
@Mr0grog Mr0grog added never-stale and removed stale labels Aug 19, 2020
@edgi-govdata-archiving edgi-govdata-archiving deleted a comment from stale bot Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants