SCORM not loading on preview domain

[igobranco]

The preview LMS domain doesn't load correctly the SCORM package, it raises a cross site scripting error.
This should also affect multi site LMS instances that use SCORM packages.

This happens because by default the SCORM storage uses only the LMS_BASE domain and not the user requested domain.

If you replace the scorm_xblock_storage function from

drydock/drydock/patches/openedx-common-settings

Line 3 in 1032bca

def scorm_xblock_storage(xblock):

With this:

def scorm_xblock_storage(xblock):
    from django.conf import settings
    from storages.backends.s3boto3 import S3Boto3Storage
    from xmodule.util.xmodule_django import get_current_request_hostname
    domain = get_current_request_hostname()
    if not domain:
      if SERVICE_VARIANT == "lms":
          domain = settings.LMS_BASE
      else:
          domain = settings.CMS_BASE
    return S3Boto3Storage(
        bucket=AWS_STORAGE_BUCKET_NAME,
        access_key=AWS_ACCESS_KEY_ID,
        secret_key=AWS_SECRET_ACCESS_KEY,
        querystring_expire=86400,
        custom_domain=f"{domain}/scorm-proxy"
    )
XBLOCK_SETTINGS["ScormXBlock"] = {
    "STORAGE_FUNC": scorm_xblock_storage,
}

Use the current user request hostname instead of the base LMS domain.

On NAU I've patched with this custom code and the SCORMs started working on preview domain.

Private references:

• https://github.com/fccn/nau-technical/issues/248
• https://github.com/fccn/nau-kubernetes-manifests/commit/f304f32a6de94028a4e96075aade2d677b210e3e#diff-c2aeec7f9cdda837fedbd54700622f44fc4975793c228e29f5cfea04dc240352

CC @MoisesGSalas @felipemontoya