From 5e3181ce61f4c18471221f5e1663f681b1bc1735 Mon Sep 17 00:00:00 2001 From: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com> Date: Mon, 24 Jun 2024 12:58:31 +0500 Subject: [PATCH] Revert "feat: add register intent prop for login segement call (#34891)" (#35021) This reverts commit a2aa6bd2dbba0f26008ec0840f62571435c3631b. --- openedx/core/djangoapps/user_authn/views/login.py | 4 +--- openedx/core/djangoapps/user_authn/views/tests/test_login.py | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/openedx/core/djangoapps/user_authn/views/login.py b/openedx/core/djangoapps/user_authn/views/login.py index 3873f13a7d49..2ad3c0ff18a0 100644 --- a/openedx/core/djangoapps/user_authn/views/login.py +++ b/openedx/core/djangoapps/user_authn/views/login.py @@ -363,15 +363,13 @@ def _track_user_login(user, request): 'MailChimp': False } ) - register_intent = request.POST.get('register_intent') == 'true' segment.track( user.id, "edx.bi.user.account.authenticated", { 'category': "conversion", 'label': request.POST.get('course_id'), - 'provider': None, - 'register_intent': register_intent, + 'provider': None }, ) diff --git a/openedx/core/djangoapps/user_authn/views/tests/test_login.py b/openedx/core/djangoapps/user_authn/views/tests/test_login.py index f72d609848ff..1e8a4c3ed510 100644 --- a/openedx/core/djangoapps/user_authn/views/tests/test_login.py +++ b/openedx/core/djangoapps/user_authn/views/tests/test_login.py @@ -1041,7 +1041,6 @@ class LoginSessionViewTest(ApiTestCase, OpenEdxEventsTestMixin): USERNAME = "bob" EMAIL = "bob@example.com" PASSWORD = "password" - REGISTER_INTENT = 'true' @classmethod def setUpClass(cls): @@ -1118,7 +1117,6 @@ def test_login(self, include_analytics, mock_segment): data = { "email": self.EMAIL, "password": self.PASSWORD, - "register_intent": self.REGISTER_INTENT, } if include_analytics: track_label = "edX/DemoX/Fall" @@ -1147,7 +1145,7 @@ def test_login(self, include_analytics, mock_segment): mock_segment.track.assert_called_once_with( expected_user_id, 'edx.bi.user.account.authenticated', - {'category': 'conversion', 'provider': None, 'label': track_label, 'register_intent': True} + {'category': 'conversion', 'provider': None, 'label': track_label} ) def test_login_with_username(self):