feat: add candidate field to RTEN model #190
Conversation
| @@ -47,3 +49,4 @@ class PearsonRTENEvent(models.Model): | |||
| content = models.JSONField() | |||
| created_at = models.DateTimeField(auto_now_add=True) | |||
| event_type = models.CharField(max_length=20, choices=EVENT_TYPE_CHOICES) | |||
| candidate = models.ForeignKey(User, null=True, on_delete=models.SET_NULL) | |||
There was a problem hiding this comment.
Do you think we could use blank=True, in order to don't be mandatory in forms or serializer.?
There was a problem hiding this comment.
I wanted to do this as mandatory as possible since the idea is that every record has a user however we don't know if the client will send the whole data in the example format and secondly the migration process complains about previous records when the null=True field is not present, that's why I added the null field and I don't think we should include the blank field
| Returns: | ||
| user (object or None): The user object associated with the anonymous user ID, or `None` if not found. | ||
| """ | ||
| anonymous_user_id = self.request.data.get("clientCandidateID", "").replace("NELC", "") |
There was a problem hiding this comment.
Ideally, we'd avoid modifying clientCandidateId(product requirement?) due to its impact on product functionality and user experience. Any changes would necessitate significant code updates related to anonymous IDs.
andrey-canon
force-pushed
the
and/add_candidate_field
branch
from
125416e
to
196e88f
Compare
andrey-canon
force-pushed
the
and/add_candidate_field
branch
from
196e88f
to
c3f7bfa
Compare
Description
This adds a new User field to the RTEN model so that the record is associated with a User record in the database. This includes the required view modifications
Testing instructions
./manage.py lms migrate eox_nelpENABLE_CERTIFICATE_PUBLISHER, this will enable the result notification pipeline and the external certificate publisher, its not necessary to test the external call so you can use an invalid mode, or if you want to test the external call setCERTIFICATE_PUBLISHER_VALID_MODESwith the desired mode{ "eventType":"RESULT_AVAILABLE", "eventTime":"?", "candidate":{ "candidateName":{ "firstName":"Maximo", "lastName":"Tercero" }, "email":"?", "lastUpdate":"?", "vueCandidateID":"?", "clientCandidateID":"?" }, "attempt":"$", "exams":{ "exam":[ { "examDefinition":{ "examSeriesCode":"?", "examLanguageCode":"?", "examName":"?", "deliveryModel":"?", "vueExamVersionId":"?", "vueExamRevisionID":"?", "clientExamVersionId":"?", "examForm":"?", "isBetaVersion":"#" }, "examResult":{ "outcomeType":"?", "startTime":"?", "timeUsed":"$", "passingScore":"0.8", "score":"0.832", "rawScore":"$", "grade":"0.5", "correct":"$", "incorrect":"$", "skipped":"$", "unscored":"$" }, "noShow":"#", "expired":"#", "ndaRefused":"#", "deliveryEventType":"?" } ] }, "vueAppointmentID":"$", "clientCode":"?", "vueCandidateID":"$", "clientCandidateID":"?" /// Complete this }Before
After
Additional information
Include anything else that will help reviewers and consumers understand the change.
Checklist for Merge