refactor: make ref checkout for picasso scripts configurable #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the use of versions different than default possible, so the code available matches the version of the workflow used.
mariajgrimaldi
force-pushed
the
MJG/picasso-version-config
branch
from
f6de871
to
998c3f9
Compare
BryanttV
reviewed
Nov 19, 2024
BryanttV
reviewed
Nov 25, 2024
| - **Extra commands**: The workflow allows running additional custom commands with ``tutor picasso run-extra-commands``. For details, refer to the `tutor-contrib-picasso`_ documentation. | ||
| - **Environment setup**: The workflow sets up and configures Tutor Virtual Environments (TVM), installs necessary plugins like ``tutor-contrib-picasso``, and prepares the environment to build and push Docker images using the `Tutor CLI`_. | ||
| - **Environment setup**: The workflow sets up installs necessary plugins like ``tutor-contrib-picasso``, and prepares the environment to build and push Docker images using the `Tutor CLI`_. |
There was a problem hiding this comment.
The README still mentions TVM:
Line 29 in 199bb1a
There was a problem hiding this comment.
Done, thank you!
| @@ -34,6 +37,9 @@ Here is an example of how to use the Picasso workflow with the inputs set: | |||
| STRAIN_PATH: redwood/base | |||
| SERVICE: mfe | |||
| ENABLE_LIMIT_BUILDKIT_PARALLELISM: false | |||
| RUNNER_WORKFLOW_LABEL: ubuntu-latest | |||
There was a problem hiding this comment.
Should we include these inputs in the README?
There was a problem hiding this comment.
I did that here: f186a2c#diff-7b3ed02bc73dc06b7db906cf97aa91dec2b2eb21f2d92bc5caa761df5bbc168fR91, thank you!
magajh
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change makes the use of versions different than default possible, so the code available matches the version of the workflow used.