Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split into 3 JARs #14

Open
msgilligan opened this issue Dec 10, 2022 · 3 comments
Open

Split into 3 JARs #14

msgilligan opened this issue Dec 10, 2022 · 3 comments

Comments

@msgilligan
Copy link
Contributor

msgilligan commented Dec 10, 2022

It would be nice if this could be split into 3 JARs:

  1. A standalone JAR for the macOS driver
  2. A standalone JAR for the Windows driver
  3. A combined (either merged or using transitive dependencies) JAR that contains the combined NativeDriver class and behaves the same as the current JAR.

This will reduce the size of the JARs and their dependencies for apps that don't need everything.

I also think the JavaFX dependency should probably be removed.

@msgilligan
Copy link
Contributor Author

This is what Gradle is reporting for dependencies:

+--- com.github.eduramiba:webcam-capture-driver-native:1.0.0-SNAPSHOT
|    +--- com.github.sarxos:webcam-capture:0.3.13-SNAPSHOT (*)
|    +--- net.java.dev.jna:jna:5.12.1
|    +--- net.java.dev.jna:jna-platform:5.12.1
|    |    \--- net.java.dev.jna:jna:5.12.1
|    +--- com.fasterxml:aalto-xml:1.3.2
|    |    \--- org.codehaus.woodstox:stax2-api:4.2
|    \--- org.slf4j:slf4j-api:2.0.5

It seems that aalto-xml is only needed for the Windows driver, right?

@eduramiba
Copy link
Owner

Right, xml processing is only necessary with the capturemanager driver. We could have 3 jars and the mac/win maven modules marked as optional in case someone does not need all.

@eduramiba
Copy link
Owner

JavaFX could also be optional, it's useful/faster to have code that directly updates the FXImage from a buffer without needing a BufferedImage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants