You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DEPR of code owner code should happen because this is likely used by 2U-only, so it is just the right thing to do.
Also, having 2U-only-code would allow us to refactor more easily:
We could drop theme. (e.g.code_owner and code_owner_squad would have the same value, and code_owner_theme would be dropped. In theory, we could also drop code_owner_squad, but that might force too much unnecessary work on other teams.
We could refactor how celery tasks get code_owner without having to support anything other than Datadog:
We could try using edx-platform's mechanism for adding additional middleware, assuming it doesn't run too late. Note: we could experimentally set a temporary span tag and see how many spans get code_owner, but don't get our new test tag.
If this didn't work out, we could consider introducing an openedx-event from DeploymentMonitoringMiddleware that allows operators to add their own custom monitoring.
Could be a separate ticket, but we used to have a New Relic search script for alerts and dashboards. It would be nice to have the same for DD for this type of work, and other monitoring refactors that have come up, like service name changes.
Initial rollout of moving code_owner monitoring code from
edx-django-utils to this plugin.
- Adds near duplicate of code owner middleware from
edx-django-utils.
- Adds code owner for celery using Datadog span processing
of celery.run spans.
- Uses temporary span tags names using `_2`, like
`code_owner_2`, for rollout and comparison with the original span tags.
See #784
code_owner
andcode_owner_squad
would have the same value, andcode_owner_theme
would be dropped. In theory, we could also dropcode_owner_squad
, but that might force too much unnecessary work on other teams.Implementation thoughts:
code_owner
, but don't get our new test tag.ACs:
The text was updated successfully, but these errors were encountered: