From 17abfaa25053f52e16fe7083ea786be74878a3c8 Mon Sep 17 00:00:00 2001 From: michaelroytman Date: Thu, 6 Jul 2023 15:24:51 -0400 Subject: [PATCH] fix: install pkg-config dependency for mysqlclient>=2.2.0 Repositiories that depend on mysqlclient>=2.2.0 will need to install the package pkg-config in their Dockerfile: PyMySQL/mysqlclient#620. This commit installs the pkg-config package in the Dockerfile. If this is missing, then pip install of mysqlclient fails with an error that includes the following: Exception: Can not find valid pkg-config name. Specify MYSQLCLIENT_CFLAGS and MYSQLCLIENT_LDFLAGS env vars manually See https://github.com/edx/edx-arch-experiments/issues/349. --- Dockerfile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Dockerfile b/Dockerfile index 2c8c7183..3a002419 100644 --- a/Dockerfile +++ b/Dockerfile @@ -14,6 +14,8 @@ MAINTAINER sre@edx.org # libmysqlclient-dev; to install header files needed to use native C implementation for # MySQL-python for performance gains. +# pkg-config; mysqlclient>=2.2.0 requires pkg-config (https://github.com/PyMySQL/mysqlclient/issues/620) + # libssl-dev; # mysqlclient wont install without this. # python3-dev; to install header files for python extensions; much wheel-building depends on this @@ -29,6 +31,7 @@ RUN apt-get update && apt-get -qy install --no-install-recommends \ python3.8 \ python3-pip \ libmysqlclient-dev \ + pkg-config \ libssl-dev \ python3-dev \ gcc \