Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Subtitles for each LOB #13

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat: Subtitles for each LOB #13

merged 1 commit into from
Jul 20, 2023

Conversation

cdeery
Copy link
Contributor

@cdeery cdeery commented Jul 20, 2023

Each line of business title should include a one sentence descriptions on the offering:

Degrees

  • Online degree programs from top universities

Bootcamps

  • Intensive, hands-on, project based learning

Executive Education

  • Expert-led, fully supported courses that build career-critical skills

Programs

  • Series of courses for a deep understanding of a topic

Courses

  • Find new interests and advance career opportunities
    image

image

image

image

Mobile:
image

image

image

image

image

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@ed66b92). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage        ?   90.80%           
=======================================
  Files           ?       30           
  Lines           ?      337           
  Branches        ?       52           
=======================================
  Hits            ?      306           
  Misses          ?       30           
  Partials        ?        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@justinhynes
Copy link
Member

Sorry if I am going to go off in the weeds here.

Semi-unrelated question from your screenshots. In one of the screenshots, it says "IT Project Manager" execute education. Since "executive education" is a product type, should it be capitalized (Execute Education?)

@cdeery
Copy link
Contributor Author

cdeery commented Jul 20, 2023

I don't think so? All of those are descriptors, like courses, programs, executive education.

@justinhynes
Copy link
Member

Additional request @cdeery -- could you provide screenshots of this in mobile view/smaller windows? Does the text still look okay?

Otherwise, this looks pretty good to me :)

@cdeery cdeery merged commit 45699ee into main Jul 20, 2023
3 checks passed
@cdeery cdeery deleted the cdeery/APER-2528/TitlesPerLOB branch July 20, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants