Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @openedx/paragon to v22 - autoclosed #147

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 11, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@openedx/paragon ^21.11.3 -> ^22.0.0 age adoption passing confidence

Release Notes

openedx/paragon (@​openedx/paragon)

v22.7.0

Compare Source

Features

v22.6.1

Compare Source

Bug Fixes

v22.6.0

Compare Source

Features

v22.5.1

Compare Source

Bug Fixes

v22.5.0

Compare Source

Features

v22.4.0

Compare Source

Features

v22.3.2

Compare Source

Bug Fixes

v22.3.1

Compare Source

Bug Fixes

v22.3.0

Compare Source

Features

v22.2.2

Compare Source

Bug Fixes
  • ensure esc key does not close modals that are blocking (#​3033) (a381182)

v22.2.1

Compare Source

Bug Fixes

v22.2.0

Compare Source

Features
  • working typings for Paragon, better types for component (#​3016) (0983219)

v22.1.1

Compare Source

Bug Fixes

v22.1.0

Compare Source

Features
  • allow consumers to configure ModalDialog to allow overflow (#​2939) (2801667)

v22.0.0

Compare Source

This release contains breaking changes to the following 4 components:

  • Chip
  • Pagination
  • SearchField
  • Form.Autosuggest

Breaking Changes

Chip

This updates the Chip component to reflect the design spec as intended.

BREAKING CHANGE: Many of the SCSS variables (i.e., tokens) surrounding Chip were removed. Consumers should verify no longer using any of the removed SCSS variables in custom Paragon brands/themes.

Pagination

This updates the Pagination component to rely on the proper button variants, rather than having all pagination buttons be of the primary variant (even when unselected) with custom styles overriding the default button variant style (e.g., background color).

It also refactors the component to be more maintainable moving forward.

BREAKING CHANGE: Many of the SCSS variables (i.e., tokens) surrounding Pagination were removed. Consumers should verify no longer using any of the removed SCSS variables in custom Paragon brands/themes.

BREAKING CHANGE: icons prop now accepts the icon src instead of an Icon component.

Before

<Pagination
  ...
  icons={{
    leftIcon: <Icon src={ChevronLeft} />,
    rightIcon: <Icon src={ChevronRight} />,
  }}
/>

After

<Pagination
  ...
  icons={{
    leftIcon: ChevronLeft,
    rightIcon: ChevronRight,
  }}
/>
SearchField

This updates the SearchField component to rely on IconButton components for its actions (e.g., reset, submit). It also ensures the external submit button in the dark variant has appropriate hover styles.

BREAKING CHANGE: icons prop now accepts the icon src instead of an Icon component.

Before

<SearchField
  ...
  icons={{
    submit: <Icon src={Search} />,
    clear: <Icon src={Close} />,
  }}
/>

After

<SearchField
  ...
  icons={{
    submit: Search,
    clear: Close,
  }}
/>
Form.Autosuggest

This updates the Autosuggest component to provide the consumer with:

  • The value entered in the textbox by the user
  • The selected value (as it is displayed in the dropdown)
  • The id of the selected option

This also allows the consumer to determine if the component should be in an error state when:

  • No text has been entered
  • Text has been entered, but not selection has been made
  • An external validation check has failed - "customError"

The consumer will provide error messages for the appropriate error states.

BREAKING CHANGE: value prop of Form.Autosuggest is now an object instead of a string

BREAKING CHANGE: Form.Autosuggest now uses onChange instead of onSelected

BREAKING CHANGE: Form.Autosuggest now takes in different error messages for value/selection required, and custom errors


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (445b365) to head (edf0dda).
Report is 178 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #147       +/-   ##
===========================================
- Coverage   91.59%   67.76%   -23.84%     
===========================================
  Files          30       43       +13     
  Lines         369      639      +270     
  Branches       68      152       +84     
===========================================
+ Hits          338      433       +95     
- Misses         30      196      +166     
- Partials        1       10        +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 2 times, most recently from a3811a7 to 0789973 Compare March 11, 2024 12:39
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch from 0789973 to cf317b5 Compare March 18, 2024 18:57
Copy link
Member

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR will need to include changes to the Form.Autosuggest value prop so that an object is passed in instead of a string.

@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 3 times, most recently from 27e774e to 21a2a2b Compare March 25, 2024 13:37
@justinhynes
Copy link
Member

@jsnwesson Does this mean we need additional changes to accept this change? Is there a ticket logged in the backlog yet? If not, I can open one.

@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 4 times, most recently from 8de29cb to 8db42d2 Compare April 1, 2024 12:39
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 3 times, most recently from 73889ca to bff23d4 Compare April 8, 2024 14:44
@jsnwesson
Copy link
Member

@justinhynes A ticket exists on our team's side to make changes to the Form.Autosuggest for this PR to be merged (APER-3330)

@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 2 times, most recently from 63db367 to 01b17ad Compare April 18, 2024 19:57
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 3 times, most recently from 1f5f529 to d95778b Compare April 23, 2024 16:39
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 4 times, most recently from 22893df to c9c09a1 Compare May 6, 2024 12:13
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 3 times, most recently from 57eceef to 64cbc05 Compare May 13, 2024 14:39
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 5 times, most recently from 8ea7648 to 2e4a72b Compare May 27, 2024 13:17
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 4 times, most recently from db1e2be to a6bbd1d Compare June 3, 2024 10:50
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 2 times, most recently from edf0dda to 8dc0549 Compare June 17, 2024 07:27
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch from 8dc0549 to 9eeefc2 Compare June 17, 2024 16:21
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 4 times, most recently from 48f69d9 to 191f97a Compare July 1, 2024 20:15
@renovate renovate bot requested a review from a team as a code owner July 1, 2024 20:15
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 5 times, most recently from ad13e54 to bee3b25 Compare July 15, 2024 10:53
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch 3 times, most recently from 78dba3c to 73212e9 Compare July 22, 2024 13:03
@renovate renovate bot force-pushed the renovate/openedx-paragon-22.x branch from 73212e9 to da54eaa Compare July 22, 2024 15:44
@renovate renovate bot changed the title fix(deps): update dependency @openedx/paragon to v22 fix(deps): update dependency @openedx/paragon to v22 - autoclosed Jul 25, 2024
@renovate renovate bot closed this Jul 25, 2024
@renovate renovate bot deleted the renovate/openedx-paragon-22.x branch July 25, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants