Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log errors on no results #39

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

cdeery
Copy link
Contributor

@cdeery cdeery commented Aug 18, 2023

Log an error when there are no results for an LOB, and also when there are no requests for any LOB.

@codecov-commenter
Copy link

Codecov Report

Merging #39 (6b71d29) into main (445b365) will increase coverage by 0.45%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   91.59%   92.05%   +0.45%     
==========================================
  Files          30       30              
  Lines         369      390      +21     
  Branches       68       71       +3     
==========================================
+ Hits          338      359      +21     
  Misses         30       30              
  Partials        1        1              
Files Changed Coverage Δ
...builder-modal/view-results/RecommendationStack.jsx 91.66% <100.00%> (+0.75%) ⬆️
.../skills-builder-modal/view-results/ViewResults.jsx 100.00% <100.00%> (ø)
...kills-builder-modal/view-results/data/constants.js 100.00% <100.00%> (ø)
...er/skills-builder-modal/view-results/data/hooks.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdeery cdeery merged commit f9201d9 into main Aug 23, 2023
4 checks passed
@cdeery cdeery deleted the cdeery/APER-2778/LogErrorsOnNoRecommendations branch August 23, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants