Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for backing up all databases #32

Open
JJGadgets opened this issue May 29, 2023 · 2 comments · May be fixed by #38
Open

Support for backing up all databases #32

JJGadgets opened this issue May 29, 2023 · 2 comments · May be fixed by #38
Labels
enhancement New feature or request

Comments

@JJGadgets
Copy link

The schickling image supports using pg_dumpall to backup all databases within a Postgres instance/cluster.

https://github.com/schickling/dockerfiles/blob/master/postgres-backup-s3/backup.sh#L65-L88

Could this also be supported in this image? This is the only missing feature holding me back from using this image over schickling's, as I'd like to have the backup be a "set it and forget it" cronjob even as more databases are added.

Would be open to try implementing it myself (will be testing against CloudNative-PG) and PR'ing the changes assuming all goes well.

@eeshugerman
Copy link
Owner

Interesting, I didn't realize the schickling repo is still merging new code.

Anyway, yes, I would be open to merging a PR for this.

@eeshugerman eeshugerman added the enhancement New feature or request label May 30, 2023
@vutsalsinghal
Copy link

vutsalsinghal commented Jun 7, 2023

@JJGadgets just curious, whats is your reason to want to switch to eeshugerman's image over schickling's? For me its BACKUP_KEEP_DAYS. Ik it can be automated with cron s3 command but since its built-in, its quite convenient!

@eeshugerman eeshugerman linked a pull request Aug 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants