Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProblemList class could be removed #268

Open
eeverman opened this issue Nov 3, 2017 · 1 comment
Open

ProblemList class could be removed #268

eeverman opened this issue Nov 3, 2017 · 1 comment

Comments

@eeverman
Copy link
Owner

eeverman commented Nov 3, 2017

This class is intended to simplify operation b/c it refuses to add nulls, but it seems like the 'weight' of this class (160 lines) is not worth it. Better to just catch the places we might add nulls and be done with it.

@eeverman eeverman modified the milestones: 0.4.x, 0.4 Nov 3, 2017
@eeverman
Copy link
Owner Author

eeverman commented Nov 3, 2017

Unfortunately it looks like this class bubbles up to a lot of areas. It would be some work to take out. Given that it is so central, maybe it could be simplified a bit. If the Unmodifiable wrapper could be simplified or taken out, it would help a lot. Possibly we don't really care if the problem lists are modifiable, since they are not production classes since any Problem will cause a RuntimeException.

@eeverman eeverman modified the milestones: 0.4, 0.4.x Dec 11, 2017
@eeverman eeverman modified the milestones: 0.4.x, 0.5.x Oct 25, 2021
@eeverman eeverman modified the milestones: 1.5.1, Next Next Dot Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant