Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default value testing to bulk tests #728

Open
eeverman opened this issue Sep 29, 2022 · 0 comments
Open

Add default value testing to bulk tests #728

eeverman opened this issue Sep 29, 2022 · 0 comments
Milestone

Comments

@eeverman
Copy link
Owner

This is related to #695 and #676.

The current bulk tests only test the getExplicitValue() method, not defaults. This makes the tests a bit counterintuitive (shouldn't that property never return null??) and also misses an entire aspect of the testing.

There are two flavors of loaders: Trimming and NonTrimming, which leads to two possible explicit values for each property. Adding another response value to test would seem to increase the number of values to test to 4 (2 x 2), however, it is simpler than that. Since the default value is only relevant when the explicit value is null, a single default value can be specified to apply to any null explicit value. Additionally, that it can only be required of the builder when one of the explicit values is null.

@eeverman eeverman added this to the 0.5.0 milestone Sep 29, 2022
@eeverman eeverman modified the milestones: 0.5.0, 0.5.1, 1.5.1, Next Next Dot Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant