Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KillAndHowBeforeEachTestExt scope is sketchy #745

Open
eeverman opened this issue Nov 10, 2022 · 0 comments
Open

KillAndHowBeforeEachTestExt scope is sketchy #745

eeverman opened this issue Nov 10, 2022 · 0 comments
Labels
Milestone

Comments

@eeverman
Copy link
Owner

KillAndHowBeforeEachTestExt uses class-level storage and operates at the test method level. This is probably just fine in this case, but it would be easier to follow the standard pattern established. working at the same storage and operation level would avoid any unexpected side effects as well and sync it up w/ the ExtensionType enum marker.

@eeverman eeverman added the bug label Nov 10, 2022
@eeverman eeverman added this to the 1.5.1 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant