Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP-55 capitalization to the payment address #219

Open
nagydani opened this issue Sep 23, 2022 · 1 comment
Open

Add EIP-55 capitalization to the payment address #219

nagydani opened this issue Sep 23, 2022 · 1 comment

Comments

@nagydani
Copy link

What was wrong?

Ordering my ticket to Devcon VI (pretix-powered), I noticed that the Ethereum address was all lower-case.
This makes copying the address more error-prone, as there is no checksum in Ethereum addresses beyond EIP-55 capitalization.

How can it be fixed?

Add EIP-55 capitalization to the payment address.

@ligi
Copy link
Member

ligi commented Sep 23, 2022

Thanks good point. We are currently revamping the plugin to single receiver mode - which (unfortunately) comes with the side-effect of having no option to manually pay. So this should be less of an issue. But still if we display Addresses it should be in ERC-55 - will see where it is still exposed after this big change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants