Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Approve #169

Closed
Jecket1 opened this issue Jul 19, 2024 · 0 comments · Fixed by #170
Closed

Batch Approve #169

Jecket1 opened this issue Jul 19, 2024 · 0 comments · Fixed by #170
Labels
enhancement New feature or request

Comments

@Jecket1
Copy link
Collaborator

Jecket1 commented Jul 19, 2024

Expected Behavior

The deal operation will not consume the authorization quota of my existing listings.

Specifications

When I need to sell an NFT, I need to perform approval in advance, so that when the transaction occurs, the contract can transfer my NFT to another address.
I have listed 1 NFT each from two different NFTs in the same Collection. The collection-level approval is set to 2. When I actively accept another user's offer to deal (transfer) one of my listed NFTs, it will not consume my existing listing quota. Instead, it will require me to initiate a new approval request.

Features:

  • Add a statistic to track all the used authorizations, and provide that information through an API endpoint.

Development Tasks:

  • Modify GetTotalEffectiveListedNFTAmountOutput logic,init default value and real value of ListedNFTTotalAmountMap.
  • Modify trade logic to update real value of ListedNFTTotalAmountMap.

Dependencies

References

@Jecket1 Jecket1 added the enhancement New feature or request label Jul 19, 2024
@Jecket1 Jecket1 mentioned this issue Jul 19, 2024
@Jecket1 Jecket1 linked a pull request Jul 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant