Double JOIN

[michaelortmann]

Its not 100% repeatable, but ive got at least one log, that shoes, eggdrop is sending out a JOIN for a chan that it already fully joined and checked out (in the following log the lines that read [s->] JOIN #test8767).

Current eggdrop git version 322bddb

Like for WHOIS, see #715, there is probably good reason for eggdrop to put the JOIN into the queue (in the following log the lines that read [!s] JOIN #test8767), but eggdrop should later, when processing the queue, filter out JOINS that are not needed anymore (or not double stack it in the first place) because it already joined.

We have config setting double-server that could fix the issue, but it defaults to 1 allowing double messages in server queue, and it could have side effects to switch it on, that i dont fully understand.

We really should investigate those kind of issues deeper and see what we can do to not send unnecessary messages to the server that we can avoid. Just having those double-* settings or their defaults do not look right.

[...]
[23:25:55] [m->] CAP END
[23:25:55] [@] :irc.example.org 001 BotA :Welcome to the ExampleNET IRC Network BotA!BotA@localhost
[23:25:55] [!s] WHOIS BotA
[23:25:55] triggering bind quotepong_unbind
[23:25:55] triggered bind quotepong_unbind, user 0.028ms sys 0.009ms
[23:25:55] triggering bind evnt:init_server
[23:25:55] [!m] MODE BotA +i-ws
[23:25:55] triggered bind evnt:init_server, user 0.041ms sys 0.014ms
[23:25:55] [!s] JOIN #test8767
[23:25:55] [@] :irc.example.org 002 BotA :Your host is irc.example.org, running version UnrealIRCd-6.1.2.3
[23:25:55] [@] :irc.example.org 003 BotA :This server was created Fri Oct 13 2023 at 06:54:19 UTC
[23:25:55] [@] :irc.example.org 004 BotA irc.example.org UnrealIRCd-6.1.2.3 diopqrstwxzBDGHIRSTWZ beIacdfhiklmnopqrstvzCDFGHKLMNOPQRSTVZ
[23:25:55] [@] :irc.example.org 005 BotA ACCOUNTEXTBAN=account,a AWAYLEN=307 BOT=B CASEMAPPING=ascii CHANLIMIT=#:10 CHANMODES=beI,fkL,lFH,cdimnprstzCDGKMNOPQRSTVZ CHANNELLEN=32 CHANTYPES=# CHATHISTORY=50 CLIENTTAGDENY=*,-draft/typing,-typing,-draft/channel-context,-draft/reply DEAF=d ELIST=MNUCT :are supported by this server
[23:25:55] [@] :irc.example.org 005 BotA EXCEPTS EXTBAN=~,acfjmnpqrtCFGOST INVEX KICKLEN=307 KNOCK MAP MAXLIST=b:60,e:60,I:60 MAXNICKLEN=30 MINNICKLEN=0 MODES=12 MONITOR=128 MSGREFTYPES=msgid,timestamp :are supported by this server
[23:25:55] [@] :irc.example.org 005 BotA NAMELEN=50 NAMESX NETWORK=ExampleNET NICKLEN=30 PREFIX=(qaohv)~&@%+ QUITLEN=307 SAFELIST SILENCE=15 STATUSMSG=~&@%+ TARGMAX=DCCALLOW:,ISON:,JOIN:,KICK:4,KILL:,LIST:,NAMES:1,NOTICE:1,PART:,PRIVMSG:4,SAJOIN:,SAPART:,TAGMSG:1,USERHOST:,USERIP:,WATCH:,WHOIS:1,WHOWAS:1 TOPICLEN=360 UHNAMES :are supported by this server
[23:25:55] [@] :irc.example.org 005 BotA USERIP WALLCHOPS WATCH=128 WATCHOPTS=A WHOX :are supported by this server
[23:25:55] [@] :irc.example.org 396 BotA Clk-8553FB0D :is now your displayed host
[23:25:55] [@] :irc.example.org 251 BotA :There are 1 users and 1 invisible on 1 servers
[23:25:55] [@] :irc.example.org 254 BotA 1 :channels formed
[23:25:55] [@] :irc.example.org 255 BotA :I have 2 clients and 0 servers
[23:25:55] [@] :irc.example.org 265 BotA 2 2 :Current local users 2, max 2
[23:25:55] [@] :irc.example.org 266 BotA 2 2 :Current global users 2, max 2
[23:25:55] [@] :irc.example.org 422 BotA :MOTD File is missing
[23:25:55] [@] :BotA MODE BotA :+iwx
[23:25:55] [!s] WHOIS BotA
[23:25:57] [m->] MODE BotA +i-ws
[23:25:57] [@] :BotA MODE BotA :-w
[23:25:57] [!s] WHOIS BotA
[23:26:00] [!s] JOIN #test8767
[23:26:03] [s->] WHOIS BotA
[23:26:03] [@] :irc.example.org 311 BotA BotA BotA Clk-8553FB0D * :/msg BotA hello
[23:26:03] [@] :irc.example.org 379 BotA BotA :is using modes +ix 
[23:26:03] [@] :irc.example.org 378 BotA BotA :is connecting from *@localhost 127.0.0.1
[23:26:03] [@] :irc.example.org 312 BotA BotA irc.example.org :ExampleNET Server
[23:26:03] [@] :irc.example.org 317 BotA BotA 7 1697318755 :seconds idle, signon time
[23:26:03] [@] :irc.example.org 318 BotA BotA :End of /WHOIS list.
[23:26:05] [s->] JOIN #test8767
[23:26:05] [@] :BotA!BotA@Clk-8553FB0D JOIN #test8767 * :/msg BotA hello
[23:26:05] BotA joined #test8767.
[23:26:05] [!m] MODE #test8767 +b
[23:26:05] [m->] MODE #test8767 +b
[23:26:05] [!m] MODE #test8767 +e
[23:26:05] [m->] MODE #test8767 +e
[23:26:05] [!m] MODE #test8767 +I
[23:26:05] [!m] MODE #test8767
[23:26:05] [!m] WHO #test8767 c%chnufat,222
[23:26:05] [@] :irc.example.org 353 BotA = #test8767 :BotA testuser
[23:26:05] [@] :irc.example.org 366 BotA #test8767 :End of /NAMES list.
[23:26:05] [@] :irc.example.org 368 BotA #test8767 :End of Channel Ban List
[23:26:05] [@] :irc.example.org 349 BotA #test8767 :End of Channel Exception List
[23:26:07] [m->] MODE #test8767 +I
[23:26:07] [@] :irc.example.org 347 BotA #test8767 :End of Channel Invite List
[23:26:09] [m->] MODE #test8767
[23:26:09] [@] :irc.example.org 324 BotA #test8767 +nt 
[23:26:09] [@] :irc.example.org 329 BotA #test8767 1697317089
[23:26:11] [m->] WHO #test8767 c%chnufat,222
[23:26:11] [@] :irc.example.org 354 BotA 222 #test8767 BotA Clk-8553FB0D BotA H 0
[23:26:11] [@] :irc.example.org 354 BotA 222 #test8767 michael Clk-8553FB0D testuser H 0
[23:26:11] [@] :irc.example.org 315 BotA #test8767 :End of /WHO list.
[23:26:17] [s->] WHOIS BotA
[23:26:17] [@] :irc.example.org 311 BotA BotA BotA Clk-8553FB0D * :/msg BotA hello
[23:26:17] [@] :irc.example.org 379 BotA BotA :is using modes +ix 
[23:26:17] [@] :irc.example.org 378 BotA BotA :is connecting from *@localhost 127.0.0.1
[23:26:17] [@] :irc.example.org 319 BotA BotA :#test8767 
[23:26:17] [@] :irc.example.org 312 BotA BotA irc.example.org :ExampleNET Server
[23:26:17] [@] :irc.example.org 317 BotA BotA 21 1697318755 :seconds idle, signon time
[23:26:17] [@] :irc.example.org 318 BotA BotA :End of /WHOIS list.
[23:26:19] [s->] WHOIS BotA
[23:26:19] [@] :irc.example.org 311 BotA BotA BotA Clk-8553FB0D * :/msg BotA hello
[23:26:19] [@] :irc.example.org 379 BotA BotA :is using modes +ix 
[23:26:19] [@] :irc.example.org 378 BotA BotA :is connecting from *@localhost 127.0.0.1
[23:26:19] [@] :irc.example.org 319 BotA BotA :#test8767 
[23:26:19] [@] :irc.example.org 312 BotA BotA irc.example.org :ExampleNET Server
[23:26:19] [@] :irc.example.org 317 BotA BotA 24 1697318755 :seconds idle, signon time
[23:26:19] [@] :irc.example.org 318 BotA BotA :End of /WHOIS list.
[23:26:21] [s->] JOIN #test8767