Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chan desync regression #1604

Open
michaelortmann opened this issue Jun 7, 2024 · 1 comment
Open

chan desync regression #1604

michaelortmann opened this issue Jun 7, 2024 · 1 comment

Comments

@michaelortmann
Copy link
Member

For eggdrop 1.9.5 #1374 has been merged

Side effect is a chan desync

For example stats.mod now continuously prints like the following every minute:

Channel '#test' desynched: 2 eggmembers vs 1 statsmembers. Resynching...

See full example log here:

https://pastebin.com/xS6Fhbj8

@michaelortmann
Copy link
Member Author

michaelortmann commented Jun 7, 2024

In this regard it is interesting that #1374 introduced the WHO_SYNC flag

because it just happened, when developing #1593, i noticed the WHO_SYNC flag in clear_channel() is used in a way, thatg i cant maintain / understand it fully, where it is altered when reset is set but then discarded in init_channel() along with the user record, that is also called when reset is set. It was decided to let it be with #1593, because no real world problem could be shown. Now here we have a real world problem that could be bound to the WHO_SYNC design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant