Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

118 log transform yi #121

Merged
merged 104 commits into from
Aug 28, 2024
Merged

118 log transform yi #121

merged 104 commits into from
Aug 28, 2024

Conversation

egouldo
Copy link
Owner

@egouldo egouldo commented Aug 28, 2024

- #102 add import tags for `log_transform()` and link to equivalent functions, apply default argument values / checks
- #97 rename out argument
- equivalent to `pred_to_z()`
- #102 write documentation
- #118 adapt response variable preparation to accept additional argument `dataset_log_transform` apply argument checks #116, add roxygen param #102
- #118 adapt response variable processing to accept either/or/none for dataset standardisation/log-transformation.
- #102 add import, return, and see also roxygen doc tags, replace note with details tag, rename fn doc title
- #116 update argument checks conditional expression
- #118 match output to `log_transform_yi()` (now returns additional cols `lower` and `upper`, not only `c("Z","VZ")`)
- #118 match process to `log_transform_yi()` and #97 generalise processing to both euc/bt datasets without hard-coding dataset names in fns, and remove associated dataset-specific argument checking #116
- #116 check appropriate required variable (i.e. function needs `back_transformed_data`, but checked for `augmented_data` in `dat` arg, wouldn't throw required error because `augmented_data` was present in `dat`
…dardisation updates

- #118 extract `lower` and `upper` transformed vals in line with addition of `log_transform_response()` / changes to `standardise_response()`
- #118 add log-transformation equivalent to `standardise_response()` and `process_resonse()`
- #102 add function documentation, including examples
…pipeline

- #118 call new arg `dataset_log_transform` in fn to log-transform outcomes for euc yi analysis
- #118 ensure application of Z_VZ_preds takes the generalised colnames yi, yi_se instead of using hard-coded dataset application #97
…lied for standardising / transformation

- accidentally deleted when upgrading for #118, have added creation of transform_datasets tibbles for all cases now, and then these will apply the appropriate functions in final code chunk at end
- `dat` to `data` to help with auto-matching in pmap within prepare_response_variables() wrapper #118
- ensure all family fns have ... arg for pmap application in prepare_response_variables() since all fns have different argument lengths and names
…ample code for `log_transform_response()`
… of transformation / standardisation in `standardise_response()`

- #118 delete old pmap helper function
@egouldo egouldo added this to the Respond Reviewer Comments milestone Aug 28, 2024
@egouldo egouldo added bug an unexpected problem or unintended behavior documentation feature a feature request or enhancement breaking change ☠️ API change likely to affect existing code upkeep maintenance, infrastructure, and similar labels Aug 28, 2024
@egouldo egouldo self-assigned this Aug 28, 2024
@egouldo egouldo linked an issue Aug 28, 2024 that may be closed by this pull request
Copy link

codefactor-io bot commented Aug 28, 2024

CodeFactor found an issue: Put a space after a comma.

It's currently on:
R\generate_outlier_subsets.R:264
Commit 79be4c8

Copy link

codefactor-io bot commented Aug 28, 2024

CodeFactor found multiple issues last seen at 79be4c8:

Add a terminal newline.

Repository owner deleted a comment from codefactor-io bot Aug 28, 2024
Copy link
Owner Author

@egouldo egouldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check listing and make suggestions

R/generate_exclusion_subsets.R Outdated Show resolved Hide resolved
R/generate_exclusion_subsets.R Outdated Show resolved Hide resolved
R/generate_exclusion_subsets.R Outdated Show resolved Hide resolved
R/generate_exclusion_subsets.R Outdated Show resolved Hide resolved
R/generate_exclusion_subsets.R Outdated Show resolved Hide resolved
R/box_cox_transform.R Outdated Show resolved Hide resolved
R/box_cox_transform.R Outdated Show resolved Hide resolved
R/box_cox_transform.R Outdated Show resolved Hide resolved
R/box_cox_transform.R Outdated Show resolved Hide resolved
R/box_cox_transform.R Outdated Show resolved Hide resolved
@egouldo egouldo merged commit 98ae1c1 into main Aug 28, 2024
1 check failed
@egouldo egouldo deleted the 118-log-transform-yi branch August 28, 2024 16:22
egouldo added a commit that referenced this pull request Aug 29, 2024
was originally only included to generate hard-coded columns, now no longer needed with #121 / #130 updates, and was never planned: <https://egouldo.github.io/ManyAnalysts/#out-of-sample-predictions-y_i-2>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code bug an unexpected problem or unintended behavior documentation feature a feature request or enhancement upkeep maintenance, infrastructure, and similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log-transform yi estimates prior to fitting MA mod
1 participant