Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicated back transformed and Z-transformed values introduced after grouping rm in pipeline #150

Closed
egouldo opened this issue Sep 6, 2024 · 1 comment
Assignees

Comments

@egouldo
Copy link
Owner

egouldo commented Sep 6, 2024

removal of grouping and lack of replacement grouping or rowdies approach has lead to duplicate values in each back_transformation / augmented_data tibble within those list-columns.

library(tidyverse)
library(ManyEcoEvo)
#> Loading required package: rmarkdown
#> Loading required package: bookdown
#> Registered S3 method overwritten by 'parsnip':
#>   method          from 
#>   print.nullmodel vegan
#> Registered S3 method overwritten by 'lava':
#>   method         from    
#>   print.estimate EnvStats

ManyEcoEvo_yi_results %>%
  pluck("effects_analysis", 1) %>%
  select(study_id, starts_with("box_cox"), contains("Z"))
#> # A tibble: 243 × 5
#>    study_id   box_cox_abs_deviation_score_estimate box_cox_var      Z      VZ
#>    <chr>                                     <dbl>       <dbl>  <dbl>   <dbl>
#>  1 Bega-1-1-1                               -2.16     0.00578  -0.783 0.00283
#>  2 Bega-1-1-1                               -2.16     0.00578  -0.783 0.00283
#>  3 Bega-1-1-1                               -2.16     0.00578  -0.783 0.00283
#>  4 Bega-2-2-1                               -0.834    0.000318 -0.320 0.00192
#>  5 Bega-2-2-1                               -0.834    0.000318 -0.320 0.00192
#>  6 Bega-2-2-1                               -0.834    0.000318 -0.320 0.00192
#>  7 Bell-2-2-1                                0.137    0.000157  0.422 0.00511
#>  8 Bell-2-2-1                                0.137    0.000157  0.422 0.00511
#>  9 Bell-2-2-1                                0.137    0.000157  0.422 0.00511
#> 10 Bell-2-2-1                                0.137    0.000157  0.422 0.00511
#> # ℹ 233 more rows

Created on 2024-09-06 with reprex v2.1.0

@egouldo egouldo self-assigned this Sep 6, 2024
@egouldo egouldo added the bug an unexpected problem or unintended behavior label Sep 6, 2024
@egouldo egouldo added this to the Respond Reviewer Comments milestone Sep 6, 2024
@egouldo egouldo changed the title Ensure back_transformation / augmented_data not removed in processing pipeline duplicated back transformed and Z-transformed values introduced after grouping rm in pipeline Sep 6, 2024
@egouldo
Copy link
Owner Author

egouldo commented Sep 10, 2024

No bug, this is because values are duplicated across reviewer id.

Local .Rprofile detected at /Users/elliotgould/Documents/GitHub/ManyEcoEvo/.Rprofile

library(tidyverse)
library(ManyEcoEvo)
#> Loading required package: rmarkdown
#> Loading required package: bookdown
#> Registered S3 method overwritten by 'parsnip':
#>   method          from 
#>   print.nullmodel vegan
#> Registered S3 method overwritten by 'lava':
#>   method         from    
#>   print.estimate EnvStats
targets::tar_read(ManyEcoEvo_yi_results) %>%
  pluck("effects_analysis", 1) %>%
  select(study_id, starts_with("box_cox_abs"), Z, VZ, ReviewerId)
#> # A tibble: 237 × 5
#>    study_id   box_cox_abs_deviation_score_estimate      Z    VZ ReviewerId
#>    <chr>                                     <dbl>  <dbl> <dbl> <chr>     
#>  1 Bega-1-1-1                              -1.48   -0.783 0.283 Rev128    
#>  2 Bega-1-1-1                              -1.48   -0.783 0.283 Rev116    
#>  3 Bega-1-1-1                              -1.48   -0.783 0.283 Rev40     
#>  4 Bega-2-2-1                              -0.891  -0.320 0.192 Rev128    
#>  5 Bega-2-2-1                              -0.891  -0.320 0.192 Rev116    
#>  6 Bega-2-2-1                              -0.891  -0.320 0.192 Rev40     
#>  7 Bell-2-2-1                               0.0815  0.422 0.511 Rev33     
#>  8 Bell-2-2-1                               0.0815  0.422 0.511 Rev151    
#>  9 Bell-2-2-1                               0.0815  0.422 0.511 Rev19     
#> 10 Bell-2-2-1                               0.0815  0.422 0.511 Rev49     
#> # ℹ 227 more rows

Created on 2024-09-10 with reprex v2.1.0

@egouldo egouldo closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
@egouldo egouldo removed the bug an unexpected problem or unintended behavior label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant