-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of the DFT derivative #20
Comments
I'll have a think about this over the weekend. Thanks. |
I think this can be done by
I think I meant to make more use of |
|
I think everything is in place with f594aad (dev branch) except for the actual modification of the DFT values and the derivative test functions. All real derivative work is done in |
Thanks. Will take a more detailed look this week. |
In another branch I've added derivative functionality but the implementation is currently horrible.
I think the interface (
Solution dsol = sol.diff(n);
) is fine butdiff
being a member function ofClass Solution
leads to some nasty stuff. Currentlydsol
is computed inSolution.cpp
which it shouldn't be, but introducing a new, i.e., DFTDerivative class leads to some circular dependencies.From some
Fixme
comments I gather you were thinking of doing some restructuring of the Solution class anyway? If you've got any suggestions on how you think the derivative code should be structured please let me know!The text was updated successfully, but these errors were encountered: