Skip to content

Commit 6de57d1

Browse files
committed
Do not try to "shutdown" UDP sockets
This is not necessary and only causes errors like "Transport endpoint is not connected". Closes #107 and #108.
1 parent 2335cf3 commit 6de57d1

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

logstash_async/transport.py

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,16 +162,20 @@ def _is_sock_write_buff_empty(self):
162162

163163
# ----------------------------------------------------------------------
164164
def _try_to_close_socket(self):
165+
self._shutdown_socket()
165166
try:
166-
self._sock.shutdown(socket.SHUT_WR)
167167
self._sock.close()
168168
except Exception as exc:
169-
self._log_close_socket_error(exc)
169+
message = f'Error on closing the transport socket: {exc}'
170+
self._log_close_socket_error(message)
171+
172+
# ----------------------------------------------------------------------
173+
def _shutdown_socket(self):
174+
pass # not necessary for UDP sockets
170175

171176
# ----------------------------------------------------------------------
172-
def _log_close_socket_error(self, exc):
173-
msg = f'Error on closing the transport socket: {exc}'
174-
safe_log_via_print('warning', msg)
177+
def _log_close_socket_error(self, message):
178+
safe_log_via_print('warning', message)
175179

176180
# ----------------------------------------------------------------------
177181
def close(self):
@@ -235,6 +239,14 @@ def _send_via_socket(self, data):
235239
data_to_send = self._convert_data_to_send(data)
236240
self._sock.sendall(data_to_send)
237241

242+
# ----------------------------------------------------------------------
243+
def _shutdown_socket(self):
244+
try:
245+
self._sock.shutdown(socket.SHUT_WR)
246+
except Exception as exc:
247+
message = f'Error on shutting down the transport socket: {exc}'
248+
self._log_close_socket_error(message)
249+
238250

239251
class BeatsTransport:
240252

0 commit comments

Comments
 (0)